lkml.org 
[lkml]   [2016]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] spi: atmel: add support for the internal chip-select of the spi controller
On Tue, Jan 05, 2016 at 09:50:54PM +0000, Måns Rullgård wrote:
> Cyrille Pitchen <cyrille.pitchen@atmel.com> writes:

> > + as->use_cs_gpios = true;
> > + if (atmel_spi_is_v2(as) &&
> > + !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> > + as->use_cs_gpios = false;
> > + master->num_chipselect = 4;
> > + }

> This part breaks the AVR32 boards and probably anything else that
> doesn't use devicetree but does use GPIOs for chip select.

Shouldn't this just be setting defaults for the case where nothing is
provided?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-01-07 17:01    [W:0.163 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site