Messages in this thread | | | Subject | Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...) | From | José Bollo <> | Date | Wed, 06 Jan 2016 10:14:58 +0100 |
| |
I prefer the use of sizeof that can't be faked even by error but why not
Le dimanche 03 janvier 2016 à 20:56 +0100, Toralf Förster a écrit : > use the definition in include/uapi/linux/xattr.h > > Signed-off-by: Toralf Förster <toralf.foerster@gmx.de> > --- > fs/ext4/xattr_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c > index 36f4c1a..1a3d629 100644 > --- a/fs/ext4/xattr_security.c > +++ b/fs/ext4/xattr_security.c > @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler, > struct dentry *dentry, char *list, size_t list_size, > const char *name, size_t name_len) > { > - const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1; > + const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN; > const size_t total_len = prefix_len + name_len + 1; > >
| |