Messages in this thread | | | Date | Tue, 5 Jan 2016 17:55:52 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC/PATCH] perf report: Show random usage tip on the help line |
| |
Em Wed, Jan 06, 2016 at 04:19:25AM +0900, Namhyung Kim escreveu: > Hi Arnaldo, > > On Tue, Jan 05, 2016 at 01:40:10PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 05, 2016 at 07:43:07PM +0900, Namhyung Kim escreveu: > > > On Tue, Jan 05, 2016 at 02:32:47PM +0800, Wangnan (F) wrote: > > > > 3. What about creating a tools/perf/Documentation/tips.txt and generate > > > > tips table dynamically?
> > > I don't see much difference doing that. I guess most of users don't > > > want to go to see the documentation anyway. Do I miss something?
> > Yes, I think what he suggests is to use: > > tips = strlist__new("file://tools/perf/Documentation/tips.txt", NULL); > > tip = strlist__entry(tips, random() % strlist__nr_entries(tips));
> > Or even do as 'perf trace' does, and have a directory with one file per > > tip, see 005438a8eef0 ("perf trace: Support 'strace' syscall event > > groups")
> Thanks for the info. It's really easy doing that, nice..
> I understand what he suggesting, but not why. :)
Because then adding new tips will not require rebuilding the tool?
I thought you didn't understood his point, judging by your "I guess most of users don't want to go to see the documentation anyway" statement, which I thought meant you thought that users would have to look at some man-page or documentation directory to go find some particular file with the tips...
- Arnaldo
| |