lkml.org 
[lkml]   [2016]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] perf tools: Add all matching dynamic sort keys for field name
On Tue, Jan 05, 2016 at 12:03:44PM +0900, Namhyung Kim wrote:

SNIP

> static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> {
> char *str, *event_name, *field_name, *opt_name;
> @@ -1995,7 +2017,12 @@ static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> }
>
> if (!strcmp(field_name, "trace_fields")) {
> - ret = add_all_dynamic_fields(evlist ,raw_trace);
> + ret = add_all_dynamic_fields(evlist, raw_trace);
> + goto out;
> + }
> +
> + if (event_name == NULL) {
> + ret = add_all_matching_fields(evlist, field_name, raw_trace);
> goto out;

should this be handled within find_evsel function:

/* case 1 */
if (event_name == NULL) {
if (evlist->nr_entries != 1) {


looks like it'd be dead code otherwise

thanks,
jirka


\
 
 \ /
  Last update: 2016-01-05 10:41    [W:0.093 / U:23.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site