Messages in this thread | | | Date | Tue, 5 Jan 2016 19:19:26 +0000 | From | Javi Merino <> | Subject | Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle |
| |
Eduardo, Rui,
On Mon, Dec 21, 2015 at 08:49:40AM +0530, Viresh Kumar wrote: > On 19-12-15, 12:54, Javi Merino wrote: > > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle > > and time_in_idle_timestamp to be as big as the number of cpus in this > > cpufreq device. However, in get_load() we access this array using the > > cpu number as index, which can result in an out of bound access. > > > > Index time_in_idle{,_timestamp} using the index in the cpufreq_device's > > allowed_cpus mask, as we do for the load_cpu array in > > cpufreq_get_requested_power() > > > > Reported-by: Nicolas Boichat <drinkcat@chromium.org> > > Cc: Amit Daniel Kachhap <amit.kachhap@gmail.com> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Cc: Zhang Rui <rui.zhang@intel.com> > > Cc: Eduardo Valentin <edubezval@gmail.com> > > Signed-off-by: Javi Merino <javi.merino@arm.com> > > --- > > drivers/thermal/cpu_cooling.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
If there are no more objections, can you pick this up?
Thanks, Javi
| |