lkml.org 
[lkml]   [2016]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 64/91] USB: whci-hcd: add check for dma mapping error
    Date
    From: Alexey Khoroshilov <khoroshilov@ispras.ru>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit f9fa1887dcf26bd346665a6ae3d3f53dec54cba1 upstream.

    qset_fill_page_list() do not check for dma mapping errors.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/usb/host/whci/qset.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c
    index dc31c425ce01..9f1c0538b211 100644
    --- a/drivers/usb/host/whci/qset.c
    +++ b/drivers/usb/host/whci/qset.c
    @@ -377,6 +377,10 @@ static int qset_fill_page_list(struct whc *whc, struct whc_std *std, gfp_t mem_f
    if (std->pl_virt == NULL)
    return -ENOMEM;
    std->dma_addr = dma_map_single(whc->wusbhc.dev, std->pl_virt, pl_len, DMA_TO_DEVICE);
    + if (dma_mapping_error(whc->wusbhc.dev, std->dma_addr)) {
    + kfree(std->pl_virt);
    + return -EFAULT;
    + }

    for (p = 0; p < std->num_pointers; p++) {
    std->pl_virt[p].buf_ptr = cpu_to_le64(dma_addr);
    --
    2.6.4


    \
     
     \ /
      Last update: 2016-01-05 19:21    [W:3.243 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site