Messages in this thread | | | Subject | Re: [PATCH v6] coccinelle: tests: unsigned value cannot be lesser than zero | From | Andrzej Hajda <> | Date | Tue, 05 Jan 2016 15:29:27 +0100 |
| |
On 01/05/2016 03:17 PM, Julia Lawall wrote: >> +@script:python depends on org@ >> +p << r_cmp.p; >> +e << r.e = ""; >> +@@ >> + >> +msg = "WARNING: Unsigned expression compared with zero: %s" % (e) >> +coccilib.org.print_todo(p[0], msg) >> + >> +@script:python depends on report@ >> +p << r_cmp.p; >> +e << r.e = ""; >> +@@ >> + >> +msg = "WARNING: Unsigned expression compared with zero: %s" % (e) >> +if e: >> + coccilib.report.print_report(p[0], msg) > Is it intentional that these don't do the same thing? The report case has > an if on e, while the org case does not. If you don't want a report when e > doesn't have a value, you could just remove the = "" from the declaration of > e. That is to give a default value of e, to allow the rule to be executed > when e doesn't have a value. > > julia > > No, I forgot to adjust it. I will fix it then, thanks.
Regards Andrzej
| |