lkml.org 
[lkml]   [2016]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] arm64: Store breakpoint single step state into pstate
Hi Will,

On 2016/1/5 0:55, Will Deacon wrote:
> Hello,
>
> On Thu, Dec 24, 2015 at 01:42:42AM +0000, Wang Nan wrote:

[SNIP]

> The problem seems to be that we take the debug exception before the
> breakpointed instruction has been executed and call perf_bp_event at
> that moment, so when we single-step the faulting instruction we actually
> step into the SIGIO handler and end up getting stuck.
>
> Your fix doesn't really address this afaict, in that you don't (can't?)
> handle:
>
> * A longjmp out of a signal handler
> * A watchpoint and a breakpoint that fire on the same instruction
> * User-controlled single-step from a signal handler that enables a
> breakpoint explicitly
> * Nested signals

Please have a look at [1], which I improve test__bp_signal() to
check bullet 2 and 4 you mentioned above. Seems my fix is correct.

[1]
http://lkml.kernel.org/g/1451969880-14877-1-git-send-email-wangnan0@huawei.com

Thank you.




\
 
 \ /
  Last update: 2016-01-05 06:41    [W:0.080 / U:35.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site