Messages in this thread | | | Date | Wed, 6 Jan 2016 10:41:50 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH 1/7] printk: Hand over printing to console if printing too long |
| |
Hello,
On (01/05/16 15:37), Jan Kara wrote: > Hi, > > On Wed 23-12-15 10:54:49, Sergey Senozhatsky wrote: > > slowly looking through the patches. > > Back from Christmas vacation... > > > How about setting 'sync_print' to 'true' in... > > bust_spinlocks() /* only set to true */ > > or > > console_verbose() /* um... may be... */ > > or > > having a separate one-liner for that > > > > void console_panic_mode(void) > > { > > sync_print = true; > > } > > > > and call it early in panic(), before we send out IPI_STOP. > > I like using console_verbose() for setting sync_print to true. That will > likely be more reliable than using oops in progress. After all > console_verbose() is used like console_panic_mode() anyway and in quite a > few places so it is a reasonable match.
Agree, only arch/microblaze/kernel/setup.c and arch/nios2/kernel/setup.c do console_verbose() early in setup_arch(), the rest seems to be what I was thinking of.
-ss
| |