lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast
    On Mon, Jan 04, 2016 at 06:40:38PM -0300, Geyslan G. Bem wrote:
    > 2016-01-04 17:58 GMT-03:00 Alan Stern <stern@rowland.harvard.edu>:
    > > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
    > >
    > >> This patch fixes coding style issues reported by checkpatch concerning
    > >> to unnecessary space after a cast.
    > >
    > > This is a case where checkpatch is wrong, IMO. Casts should always be
    > > followed by a space. I will not accept this patch.
    > Ok. I understand.
    >
    > >
    > > This must be something recently added to checkpatch. It never used to
    > > complain about casts, whether they were followed by a space or not.
    > I'm using the checkpatch --strict option.

    Please never use that on existing kernel code, except for
    drivers/staging/ stuff, otherwise your patches will start to very
    quickly be ignored.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2016-01-04 23:01    [W:2.465 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site