lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 07/17] usb: host: ehci-dbg: fix unsigned comparison
Date
This patch fixes an unsigned comparison to less than 0.

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---

Notes:
I'm not sure about that comparison because in qh_lines() temp receives
the snprintf() return and thereafter occurs this comparison:

if (size < temp)
temp = size;

Is it a test of string truncation right? That possibility is being
treated. But if after some snprintf returns the temp is exactly size
minus 1 (trailing null)? Could this scenario happen? If yes, I think
size could be not counting correctly. Let me know more about it.

drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 980ca55..1645120 100644
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -542,7 +542,7 @@ static ssize_t fill_async_buffer(struct debug_buffer *buf)
next += temp;

list_for_each_entry(qh, &ehci->async_unlink, unlink_node) {
- if (size <= 0)
+ if (size == 0)
break;
qh_lines(ehci, qh, &next, &size);
}
--
2.6.4


\
 
 \ /
  Last update: 2016-01-04 22:01    [W:0.140 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site