Messages in this thread | | | Date | Mon, 4 Jan 2016 20:46:29 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support |
| |
On Mon, Jan 04, 2016 at 11:17:29AM -0600, Dinh Nguyen wrote: > We tried to jam the L2 and OCRAM EDAC functionality in the same > altr_edac.c file. It looks like it might be clean if we split out the L2 > and OCRAM functions into their appropriate files(altr_edac_l2.c and > altr_edac_ocram.c). Do you agree?
"Clean" in what sense? To me clean is when there's a single compilation unit altera_edac.c which contains all Altera-specific code.
> These bindings were in a separate patch that you were not CC'd. I'll > keep you on the entire patch set in the future.
Yes, I believe the devicetree definitions need to go hand-in-hand with its user(s).
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |