lkml.org 
[lkml]   [2016]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4.1 03/13] tools lib traceevent: Factor out and export print_event_field[s]
Em Mon, Jan 04, 2016 at 10:31:27AM -0500, Steven Rostedt escreveu:
> On Wed, 23 Dec 2015 22:08:41 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
>
> > The print_event_field() and print_event_fields() are to print basic
> > information of a given field or event without the print format. They'll
> > be used by dynamic sort keys later.
>
> Hi Namhyung,
>
>
> > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> > index 6fc83c7edbe9..600c73277a6f 100644
> > --- a/tools/lib/traceevent/event-parse.h
> > +++ b/tools/lib/traceevent/event-parse.h
> > @@ -705,6 +705,10 @@ struct cmdline *pevent_data_pid_from_comm(struct pevent *pevent, const char *com
> > struct cmdline *next);
> > int pevent_cmdline_pid(struct pevent *pevent, struct cmdline *cmdline);
> >
> > +void print_event_field(struct trace_seq *s, void *data,
> > + struct format_field *field);
> > +void print_event_fields(struct trace_seq *s, void *data,
> > + int size __maybe_unused, struct event_format *event);
>
> I'm fine with the patch, but can you change the function names to be
> less generic, as this will now be part of a library (that I hope will
> become something supplied by distros soon).
>
> Like:
>
> pevent_print_field();
> and
> pevent_print_fields();

Sure, I did those changes in my tree as we discussed over IRC, as well
added your Acked-by,

thanks,

- Arnaldo

> Thanks!
>
> -- Steve
>
> > void pevent_event_info(struct trace_seq *s, struct event_format *event,
> > struct pevent_record *record);
> > int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,


\
 
 \ /
  Last update: 2016-01-04 20:01    [W:0.340 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site