lkml.org 
[lkml]   [2016]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 1/3] rdmacg: Added rdma cgroup controller.
Hi Parav,

[auto build test ERROR on cgroup/for-next]
[also build test ERROR on v4.5-rc1 next-20160129]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Parav-Pandit/rdmacg-IB-core-rdma-controller-support/20160131-063313
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All error/warnings (new ones prefixed by >>):

In file included from arch/x86/include/asm/bug.h:35:0,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/gfp.h:4,
from include/linux/slab.h:14,
from kernel/cgroup_rdma.c:8:
kernel/cgroup_rdma.c: In function 'find_cg_rpool_locked':
>> include/linux/lockdep.h:340:51: error: invalid type argument of '->' (have 'spinlock_t {aka struct spinlock}')
#define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
^
include/asm-generic/bug.h:86:25: note: in definition of macro 'WARN_ON'
int __ret_warn_on = !!(condition); \
^
>> include/linux/lockdep.h:366:27: note: in expansion of macro 'lockdep_is_held'
WARN_ON(debug_locks && !lockdep_is_held(l)); \
^
>> kernel/cgroup_rdma.c:179:2: note: in expansion of macro 'lockdep_assert_held'
lockdep_assert_held(cg->rpool_list_lock);
^

coccinelle warnings: (new ones prefixed by >>)

>> kernel/cgroup_rdma.c:912:1-7: preceding lock on line 879
--
>> kernel/cgroup_rdma.c:787:2-3: Unneeded semicolon
kernel/cgroup_rdma.c:611:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

vim +340 include/linux/lockdep.h

7531e2f34 Peter Zijlstra 2008-08-11 334 int trylock, int read, int check,
7531e2f34 Peter Zijlstra 2008-08-11 335 struct lockdep_map *nest_lock, unsigned long ip);
fbb9ce953 Ingo Molnar 2006-07-03 336
fbb9ce953 Ingo Molnar 2006-07-03 337 extern void lock_release(struct lockdep_map *lock, int nested,
fbb9ce953 Ingo Molnar 2006-07-03 338 unsigned long ip);
fbb9ce953 Ingo Molnar 2006-07-03 339
f607c6685 Peter Zijlstra 2009-07-20 @340 #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
f607c6685 Peter Zijlstra 2009-07-20 341
f607c6685 Peter Zijlstra 2009-07-20 342 extern int lock_is_held(struct lockdep_map *lock);
f607c6685 Peter Zijlstra 2009-07-20 343
00ef9f734 Peter Zijlstra 2008-12-04 344 extern void lock_set_class(struct lockdep_map *lock, const char *name,
00ef9f734 Peter Zijlstra 2008-12-04 345 struct lock_class_key *key, unsigned int subclass,
64aa348ed Peter Zijlstra 2008-08-11 346 unsigned long ip);
64aa348ed Peter Zijlstra 2008-08-11 347
00ef9f734 Peter Zijlstra 2008-12-04 348 static inline void lock_set_subclass(struct lockdep_map *lock,
00ef9f734 Peter Zijlstra 2008-12-04 349 unsigned int subclass, unsigned long ip)
00ef9f734 Peter Zijlstra 2008-12-04 350 {
00ef9f734 Peter Zijlstra 2008-12-04 351 lock_set_class(lock, lock->name, lock->key, subclass, ip);
00ef9f734 Peter Zijlstra 2008-12-04 352 }
00ef9f734 Peter Zijlstra 2008-12-04 353
cf40bd16f Nick Piggin 2009-01-21 354 extern void lockdep_set_current_reclaim_state(gfp_t gfp_mask);
cf40bd16f Nick Piggin 2009-01-21 355 extern void lockdep_clear_current_reclaim_state(void);
cf40bd16f Nick Piggin 2009-01-21 356 extern void lockdep_trace_alloc(gfp_t mask);
cf40bd16f Nick Piggin 2009-01-21 357
a24fc60d6 Peter Zijlstra 2015-06-11 358 extern void lock_pin_lock(struct lockdep_map *lock);
a24fc60d6 Peter Zijlstra 2015-06-11 359 extern void lock_unpin_lock(struct lockdep_map *lock);
a24fc60d6 Peter Zijlstra 2015-06-11 360
cf40bd16f Nick Piggin 2009-01-21 361 # define INIT_LOCKDEP .lockdep_recursion = 0, .lockdep_reclaim_gfp = 0,
fbb9ce953 Ingo Molnar 2006-07-03 362
e3a55fd18 Jarek Poplawski 2007-03-22 363 #define lockdep_depth(tsk) (debug_locks ? (tsk)->lockdep_depth : 0)
d5abe6691 Peter Zijlstra 2006-12-06 364
b1ae345d9 Johannes Berg 2013-02-21 365 #define lockdep_assert_held(l) do { \
b1ae345d9 Johannes Berg 2013-02-21 @366 WARN_ON(debug_locks && !lockdep_is_held(l)); \
b1ae345d9 Johannes Berg 2013-02-21 367 } while (0)
f607c6685 Peter Zijlstra 2009-07-20 368
9a37110d2 Peter Hurley 2014-09-10 369 #define lockdep_assert_held_once(l) do { \

:::::: The code at line 340 was first introduced by commit
:::::: f607c6685774811b8112e124f10a053d77015485 lockdep: Introduce lockdep_assert_held()

:::::: TO: Peter Zijlstra <a.p.zijlstra@chello.nl>
:::::: CC: Ingo Molnar <mingo@elte.hu>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2016-01-31 02:01    [W:0.085 / U:0.620 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site