lkml.org 
[lkml]   [2016]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH V3] net: emac: emac gigabit ethernet controller driver
    On Fri, Jan 29, 2016 at 2:38 PM, Timur Tabi <timur@codeaurora.org> wrote:
    > Rob Herring wrote:

    [...]

    >>>> Isn't this a user enabled feature if the h/w supports it?
    >>>
    >>>
    >>>
    >>> Is there a sysfs entry for that? We were planning on having a similar
    >>> ACPI
    >>> property.
    >>
    >>
    >> It would be in ethtool I think.
    >
    >
    > Ah, this driver does not support ethtool yet.
    >
    > However, based on a cursory look of ethtool, it appears that there's only an
    > option to query the current timestamp, but not actually enable/disable the
    > feature. The e1000e driver, for example, just forces the feature by default
    > for various chips. Is there any reason why we shouldn't enable it if the
    > hardware supports it?

    Probably not. You simply ignore the timestamp if you don't care. So
    then why do you want a DT property?

    Rob

    \
     
     \ /
      Last update: 2016-01-30 23:21    [W:3.017 / U:1.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site