Messages in this thread | | | From | Rob Herring <> | Date | Sat, 30 Jan 2016 15:58:29 -0600 | Subject | Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver |
| |
On Fri, Jan 29, 2016 at 2:38 PM, Timur Tabi <timur@codeaurora.org> wrote: > Rob Herring wrote:
[...]
>>>> Isn't this a user enabled feature if the h/w supports it? >>> >>> >>> >>> Is there a sysfs entry for that? We were planning on having a similar >>> ACPI >>> property. >> >> >> It would be in ethtool I think. > > > Ah, this driver does not support ethtool yet. > > However, based on a cursory look of ethtool, it appears that there's only an > option to query the current timestamp, but not actually enable/disable the > feature. The e1000e driver, for example, just forces the feature by default > for various chips. Is there any reason why we shouldn't enable it if the > hardware supports it?
Probably not. You simply ignore the timestamp if you don't care. So then why do you want a DT property?
Rob
| |