lkml.org 
[lkml]   [2016]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/3] ACPI: amba bus probing support
On Wed, Dec 23, 2015 at 05:19:40PM +0300, Aleksey Makarov wrote:
> + dev = amba_device_alloc(NULL, 0, 0);
> + if (!dev) {
> + dev_err(&adev->dev, "%s(): amba_device_alloc() failed\n",
> + __func__);
> + return -ENOMEM;
> + }
...
> + /*
> + * If the ACPI node has a parent and that parent has a physical device
> + * attached to it, that physical device should be the parent of the
> + * platform device we are about to create.
> + */
> + dev->dev.parent = NULL;

No need to initialise this; amba_device_alloc() uses kzalloc(), and so
dev->dev.parent will already be NULL.

...
> + dev_set_name(&dev->dev, "%s", dev_name(&adev->dev));

Is there a reason not to use:

dev = amba_device_alloc(dev_name(&adev->dev), 0, 0);

above?

--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


\
 
 \ /
  Last update: 2016-01-03 15:01    [W:0.081 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site