[lkml]   [2016]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/5] nbd: Remove signal usage
Hi Markus,

this looks great!

Reviewed-by: Christoph Hellwig <>

One thing I noticed, which might be a good cleanup in the future:

> - spin_lock_irqsave(&nbd->tasks_lock, flags);
> nbd->task_recv = current;
> - spin_unlock_irqrestore(&nbd->tasks_lock, flags);

It seems like task_{send,recv} are only used for the files showing
the pids. Maybe you should just store the pids directly in the
nbd_device structure and also keep the sysfs file around for the
life time of that structure.

 \ /
  Last update: 2016-01-03 13:21    [W:0.081 / U:3.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site