lkml.org 
[lkml]   [2016]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] staging: rtl8723au: Fixes unnecessary return warning
    From
    Date
    On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote:
    > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
    > > Bhaktipriya Shridhar <bhaktipriya96@gmail.com> writes:
    > > > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
    > > > WARNING: void function return statements are not generally useful
    []
    > > > diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
    []
    > > > @@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)
    > > >
    > > >       dump_mgntframe23a(padapter, pmgntframe);
    > > >
    > > > -     return;
    > > >  }
    > >
    > > If you insist on pushing this rather unncessary change, please do it
    > > properly, and remove the blank line before the return statement as well.
    >
    > As Jes said, you need to remove the blank lines before the returns
    > too. checkpatch should have picked this up, you did run the patch
    > through checkpatch before you sent it, right?

    checkpatch doesn't pick this up.

    If you'd like to make it do so, you're welcome to try
    but it's likely a bit more complicated than it appears.

    \
     
     \ /
      Last update: 2016-01-30 02:41    [W:3.613 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site