Messages in this thread | | | Date | Thu, 28 Jan 2016 22:34:43 -0800 | From | Greg KH <> | Subject | Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file. |
| |
On Thu, Dec 17, 2015 at 12:46:14PM +0530, Sudip Mukherjee wrote: > On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote: > > The original code defined macros in the source code, making it > > harder to read. Moved them to the header file, as per the TODO file. > > > > Updated the TODO file. > > I think the TODO file should not be updated now. There are still some > macros in skein_block.c.
I agree, it can't be removed just yet, this patch needs to be redone before I can take it.
thanks,
greg k-h
| |