lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 151/210] SCSI: initio: remove duplicate module device table
    Date
    3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit d282e2b383e3f41a7758e8cbf3076091ef9d9447 upstream.

    The initio driver has for many years had two copies of the
    same module device table. One of them is also used for registering
    the other driver, the other one is entirely useless after the
    large scale cleanup that Alan Cox did back in 2007.

    The compiler warns about this whenever the driver is built-in:

    drivers/scsi/initio.c:131:29: warning: 'i91u_pci_devices' defined but not used [-Wunused-variable]

    This removes the extraneous table and the warning.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Fixes: 72d39fea901 ("[SCSI] initio: Convert into a real Linux driver and update to modern style")
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/scsi/initio.c | 16 ----------------
    1 file changed, 16 deletions(-)

    diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
    index e5dae7b..5106317 100644
    --- a/drivers/scsi/initio.c
    +++ b/drivers/scsi/initio.c
    @@ -110,11 +110,6 @@
    #define i91u_MAXQUEUE 2
    #define i91u_REVID "Initio INI-9X00U/UW SCSI device driver; Revision: 1.04a"

    -#define I950_DEVICE_ID 0x9500 /* Initio's inic-950 product ID */
    -#define I940_DEVICE_ID 0x9400 /* Initio's inic-940 product ID */
    -#define I935_DEVICE_ID 0x9401 /* Initio's inic-935 product ID */
    -#define I920_DEVICE_ID 0x0002 /* Initio's other product ID */
    -
    #ifdef DEBUG_i91u
    static unsigned int i91u_debug = DEBUG_DEFAULT;
    #endif
    @@ -127,17 +122,6 @@ static int setup_debug = 0;

    static void i91uSCBPost(u8 * pHcb, u8 * pScb);

    -/* PCI Devices supported by this driver */
    -static struct pci_device_id i91u_pci_devices[] = {
    - { PCI_VENDOR_ID_INIT, I950_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
    - { PCI_VENDOR_ID_INIT, I940_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
    - { PCI_VENDOR_ID_INIT, I935_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
    - { PCI_VENDOR_ID_INIT, I920_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
    - { PCI_VENDOR_ID_DOMEX, I920_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
    - { }
    -};
    -MODULE_DEVICE_TABLE(pci, i91u_pci_devices);
    -
    #define DEBUG_INTERRUPT 0
    #define DEBUG_QUEUE 0
    #define DEBUG_STATE 0
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-29 03:21    [W:4.085 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site