Messages in this thread | | | Date | Thu, 28 Jan 2016 09:22:04 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] cputime: Fix timeval-->cputime conversion |
| |
Cc'ing Arnd
On Thu, 28 Jan 2016, zengtao wrote:
> The structure: > struct timeval { > __kernel_time_t tv_sec; /* seconds */ > __kernel_suseconds_t tv_usec; /* microseconds */ > }; > both __kernel_time_t and __kernel_suseconds_t are short than u64 > when it is 32bit platform, so force u64 conversion here. > > Signed-off-by: zengtao <prime.zeng@huawei.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> --- > include/asm-generic/cputime_nsecs.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/cputime_nsecs.h b/include/asm-generic/cputime_nsecs.h > index 0419485..e2f7ff9 100644 > --- a/include/asm-generic/cputime_nsecs.h > +++ b/include/asm-generic/cputime_nsecs.h > @@ -91,7 +91,8 @@ static inline void cputime_to_timespec(const cputime_t ct, struct timespec *val) > */ > static inline cputime_t timeval_to_cputime(const struct timeval *val) > { > - u64 ret = val->tv_sec * NSEC_PER_SEC + val->tv_usec * NSEC_PER_USEC; > + u64 ret = (u64)val->tv_sec * NSEC_PER_SEC + > + val->tv_usec * NSEC_PER_USEC; > return (__force cputime_t) ret; > } > static inline void cputime_to_timeval(const cputime_t ct, struct timeval *val) > -- > 1.9.1 > >
| |