Messages in this thread | | | From | Richard Zhu <> | Subject | RE: [RFC 3/4] ARM: imx: add the platform related rpmsg implementation | Date | Thu, 28 Jan 2016 06:33:00 +0000 |
| |
Thanks a lot.
Best Regards hongxing zhu Linux BSP team Office: 86-21-28937189 Email: hongxing.zhu@nxp.com
-----Original Message----- From: Shawn Guo [mailto:shawnguo@kernel.org] Sent: Thursday, January 28, 2016 1:50 PM To: Richard Zhu Cc: ohad@wizery.com; Stefan Agner; linux-kernel@vger.kernel.org Subject: Re: [RFC 3/4] ARM: imx: add the platform related rpmsg implementation
On Thu, Jan 28, 2016 at 02:17:21AM +0000, Richard Zhu wrote: > > arch/arm/mach-imx/Kconfig | 12 ++ > > arch/arm/mach-imx/Makefile | 2 + > > arch/arm/mach-imx/imx_rpmsg.c | 364 ++++++++++++++++++++++++++++++++++++++++++ > > arch/arm/mach-imx/mu.c | 217 +++++++++++++++++++++++++ > > I'm not rpmsg expert, but it seems to me that the driver should be put into drivers/rpmsg/ rather than mach-imx. > [Richard] This part rpmsg codes are closed related to the platform. For example, kinds of ops callback functions. > Thus, these codes are placed into arch/arm/mach-imx/ folder. BTW, so does to omap rpmsg implementation. > http://omappedia.org/wiki/RPMsg_Kernel_Sources
Okay, I will find some time slot to get myself familiar with rpmsg subsystem and then review the patch.
Shawn
| |