lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 1/4] mfd: f81504-core: Add Fintek F81504/508/512 PCIE-to-UART/GPIO core support
From
Date
Hi Alan,

One Thousand Gnomes 於 2016/1/28 下午 06:04 寫道:
>> + Please bulit-in kernel if you need early console support.
> This driver needs to be built into the kernel to use early console
> support.
>

ok

>> + switch (dev->device) {
>> + case FINTEK_F81504: /* 4 ports */
>> + /* F81504 max 2 sets of GPIO, others are max 6 sets*/
>> + gpio_en &= 0x03;
>> + case FINTEK_F81508: /* 8 ports */
>> + max_port = dev->device & 0xff;
>
> If that is meant to fall through from F81504 into F81508 it's worth
> commenting, otherwise someone reviewing the code can't always be sure it
> was intentional.

ok, I'll add comments to describe this.

>> + /* Get the UART IO address dispatch from the BIOS */
>> + pci_read_config_dword(dev, 0x24, &bar_data[0]);
>> + pci_read_config_dword(dev, 0x20, &bar_data[1]);
>> + pci_read_config_dword(dev, 0x1c, &bar_data[2]);
>
> Take these from the pci device itself. On some non PC platforms the
> values in the pci bar may be remapped by bridges and not give you the
> true answer.
>
> pci_resource_start(dev, barnumber)
>

Thanks for point this out, I'll rewrite here with pci_resource_start().
--
With Best Regards,
Peter Hung

\
 
 \ /
  Last update: 2016-01-29 03:41    [W:0.132 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site