lkml.org 
[lkml]   [2016]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 078/210] ASoC: compress: Fix compress device direction check
    Date
    3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Vinod Koul <vinod.koul@intel.com>

    commit a1068045883ed4a18363a4ebad0c3d55e473b716 upstream.

    The detection of direction for compress was only taking into account codec
    capabilities and not CPU ones. Fix this by checking the CPU side capabilities
    as well

    Tested-by: Ashish Panwar <ashish.panwar@intel.com>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/soc/soc-compress.c | 23 ++++++++++++++++++++---
    1 file changed, 20 insertions(+), 3 deletions(-)

    diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
    index 025c38f..1874cf0 100644
    --- a/sound/soc/soc-compress.c
    +++ b/sound/soc/soc-compress.c
    @@ -623,6 +623,7 @@ int soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
    struct snd_pcm *be_pcm;
    char new_name[64];
    int ret = 0, direction = 0;
    + int playback = 0, capture = 0;

    if (rtd->num_codecs > 1) {
    dev_err(rtd->card->dev, "Multicodec not supported for compressed stream\n");
    @@ -634,11 +635,27 @@ int soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
    rtd->dai_link->stream_name, codec_dai->name, num);

    if (codec_dai->driver->playback.channels_min)
    + playback = 1;
    + if (codec_dai->driver->capture.channels_min)
    + capture = 1;
    +
    + capture = capture && cpu_dai->driver->capture.channels_min;
    + playback = playback && cpu_dai->driver->playback.channels_min;
    +
    + /*
    + * Compress devices are unidirectional so only one of the directions
    + * should be set, check for that (xor)
    + */
    + if (playback + capture != 1) {
    + dev_err(rtd->card->dev, "Invalid direction for compress P %d, C %d\n",
    + playback, capture);
    + return -EINVAL;
    + }
    +
    + if(playback)
    direction = SND_COMPRESS_PLAYBACK;
    - else if (codec_dai->driver->capture.channels_min)
    - direction = SND_COMPRESS_CAPTURE;
    else
    - return -EINVAL;
    + direction = SND_COMPRESS_CAPTURE;

    compr = kzalloc(sizeof(*compr), GFP_KERNEL);
    if (compr == NULL) {
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-29 03:41    [W:4.030 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site