Messages in this thread | | | Date | Wed, 27 Jan 2016 13:52:18 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH] mm: vmscan: do not clear SHRINKER_NUMA_AWARE if nr_node_ids == 1 |
| |
On Wed, Jan 27, 2016 at 07:47:22PM +0300, Vladimir Davydov wrote: > Currently, on shrinker registration we clear SHRINKER_NUMA_AWARE if > there's the only NUMA node present. The comment states that this will > allow us to save some small loop time later. It used to be true when > this code was added (see commit 1d3d4437eae1b ("vmscan: per-node > deferred work")), but since commit 6b4f7799c6a57 ("mm: vmscan: invoke > slab shrinkers from shrink_zone()") it doesn't make any difference. > Anyway, running on non-NUMA machine shouldn't make a shrinker NUMA > unaware, so zap this hunk. > > Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |