lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card
On Tue, Jan 26, 2016 at 02:34:26PM +0000, Damien Horsley wrote:

> + - clock-names : Includes the following entries:
> + "audio_pll" The audio PLL
> + "i2s_mclk" The i2s reference clock
> + Also connected to i2s_out_0_mclk output
> + "dac_mclk" Dac reference clock. Connected to i2s_dac_clk output

Why are these (especially the dac_mclk and i2s_mclk) properties of the
card and not of the drivers for the respective devices?

> + - img,mute-gpio : phandle of the mute gpio
> +
> + - img,hp-det-gpio : phandle of the headphone detect gpio

The DT maintainers would prefer those to be named -gpios.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-01-27 16:01    [W:0.104 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site