lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH v2] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.
On Mon, 25 Jan 2016, John Stultz wrote:
> From: Ruchi Kandoi <kandoiruchi@google.com>
>
> This allows power/performance management software to set timer
> slack for other threads according to its policy for the thread
> (such as when the thread is designated foreground vs. background
> activity)
>
> Second argument is similar to PR_SET_TIMERSLACK, if non-zero
> then the slack is set to that value otherwise sets it to the
> default for the thread.
>
> Takes PID of the thread as the third argument.
>
> This interface checks that the calling task has permissions to
> to use PTRACE_MODE_ATTACH on the target task, so that we can
> ensure arbitrary apps do not change the timer slack for other
> apps.
>
> Additional fixes from Ruchi and Micha Kalfon <micha@cellrox.com>
> have been folded into this patch to make it easier to reivew.
>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Oren Laadan <orenl@cellrox.com>
> Cc: Micha Kalfon <micha@cellrox.com>
> Cc: Ruchi Kandoi <kandoiruchi@google.com>
> Cc: Rom Lemarchand <romlem@android.com>
> Cc: Android Kernel Team <kernel-team@android.com>
> Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
> [jstultz:
> * Folded in CAP_SYS_NICE check from Ruchi.
> * Folded in fix misplaced PR_SET_TIMERSLACK_PID case fix from
> Micha.
> * Folded in make PR_SET_TIMERSLACK_PID pid namespace aware fix
> from Micha.
> * Changed PR_SET_TIMERSLACK_PID so it didn't collide with
> already upstream prctrl values.
> * Reworked commit message.
> * Moved from CAP_SYS_NICE to PTRACE_MODE_ATTACH for permissions
> checks]
> Signed-off-by: John Stultz <john.stultz@linaro.org>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

\
 
 \ /
  Last update: 2016-01-27 13:01    [W:0.512 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site