lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 258/268] bridge: Only call /sbin/bridge-stp for the initial network namespace
    Date
    4.2.8-ckt3 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Hannes Frederic Sowa <hannes@stressinduktion.org>

    [ Upstream commit ff62198553e43cdffa9d539f6165d3e83f8a42bc ]

    [I stole this patch from Eric Biederman. He wrote:]

    > There is no defined mechanism to pass network namespace information
    > into /sbin/bridge-stp therefore don't even try to invoke it except
    > for bridge devices in the initial network namespace.
    >
    > It is possible for unprivileged users to cause /sbin/bridge-stp to be
    > invoked for any network device name which if /sbin/bridge-stp does not
    > guard against unreasonable arguments or being invoked twice on the
    > same network device could cause problems.

    [Hannes: changed patch using netns_eq]

    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/bridge/br_stp_if.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
    index 4ca449a..49d8d28 100644
    --- a/net/bridge/br_stp_if.c
    +++ b/net/bridge/br_stp_if.c
    @@ -130,7 +130,10 @@ static void br_stp_start(struct net_bridge *br)
    char *envp[] = { NULL };
    struct net_bridge_port *p;

    - r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC);
    + if (net_eq(dev_net(br->dev), &init_net))
    + r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC);
    + else
    + r = -ENOENT;

    spin_lock_bh(&br->lock);

    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-27 22:01    [W:4.056 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site