lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 073/268] bcache: unregister reboot notifier if bcache fails to unregister device
    Date
    4.2.8-ckt3 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Zheng Liu <wenqing.lz@taobao.com>

    commit 2ecf0cdb2b437402110ab57546e02abfa68a716b upstream.

    In bcache_init() function it forgot to unregister reboot notifier if
    bcache fails to unregister a block device. This commit fixes this.

    Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
    Tested-by: Joshua Schmid <jschmid@suse.com>
    Tested-by: Eric Wheeler <bcache@linux.ewheeler.net>
    Cc: Kent Overstreet <kmo@daterainc.com>
    Signed-off-by: Jens Axboe <axboe@fb.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/md/bcache/super.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
    index f13b0e2..c70755d 100644
    --- a/drivers/md/bcache/super.c
    +++ b/drivers/md/bcache/super.c
    @@ -2099,8 +2099,10 @@ static int __init bcache_init(void)
    closure_debug_init();

    bcache_major = register_blkdev(0, "bcache");
    - if (bcache_major < 0)
    + if (bcache_major < 0) {
    + unregister_reboot_notifier(&reboot);
    return bcache_major;
    + }

    if (!(bcache_wq = create_workqueue("bcache")) ||
    !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-01-27 22:01    [W:7.034 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site