Messages in this thread | | | Date | Tue, 26 Jan 2016 18:31:49 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere |
| |
On Thu, 21 Jan 2016, Zhao Qiang wrote:
> 127 is the theoretical up boundary of QEIC number, > in fact there only be 44 qe_ic_info now. > add check to overflow for qe_ic_info
How do you trigger that overflow? The above does not explain WHY we need these checks.
> diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c > index 5419527..90c00b7 100644 > --- a/drivers/soc/fsl/qe/qe_ic.c > +++ b/drivers/soc/fsl/qe/qe_ic.c
Sigh. Another dump ground for SOC stuff? irq chip drivers belong into drivers/irqchip.
Thanks,
tglx
| |