lkml.org 
[lkml]   [2016]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] checkpatch: fix left brace warning
From
Hello,

2015-12-30 12:49 GMT-03:00 Geyslan G. Bem <geyslan@gmail.com>:
> This patch escapes a regex that uses left brace.
>
> Using checkpatch.pl with Perl 5.22.0 generates the warning: "Unescaped
> left brace in regex is deprecated, passed through in regex;"
>
> Comment from regcomp.c in Perl source: "Currently we don't warn when the
> lbrace is at the start of a construct. This catches it in the middle of
> a literal string, or when it's the first thing after something like
> "\b"."
>
> This works as a complement to 4e5d56bd.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> Suggested-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d4960f7..3e11a30 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4108,7 +4108,7 @@ sub process {
> ## }
>
> #need space before brace following if, while, etc
> - if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\){/) ||
> + if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\)\{/) ||
> $line =~ /do\{/) {
> if (ERROR("SPACING",
> "space required before the open brace '{'\n" . $herecurr) &&
> --
> 2.6.4
>

This was acked?


--
Regards,

Geyslan G. Bem
hackingbits.com

\
 
 \ /
  Last update: 2016-01-26 16:41    [W:1.513 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site