Messages in this thread | | | Subject | Re: [PATCH v2] ata: add AMD Seattle platform driver | From | Hans de Goede <> | Date | Tue, 26 Jan 2016 10:36:57 +0100 |
| |
Hi,
On 25-01-16 21:43, Tejun Heo wrote: > On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote: >> AMD Seattle SATA controller mostly conforms to AHCI interface with some >> special register to control SGPIO interface. In the case of an AHCI >> controller, the SGPIO feature is ideally implemented using the >> "Enclosure Management" register of the AHCI controller, but those >> registeres are not implemented in the Seattle SoC. Instead SoC >> (Rev B0 onwards) provides a 32-bit SGPIO control register which should >> be programmed to control the activity, locate and fault LEDs. >> >> The driver is based on ahci_platform driver. >> >> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com> >> Acked-by: Hans de Goede <hdegoede@redhat.com> >> CC: tj@kernel.org >> CC: linux-ide@vger.kernel.org > > Hans, can you please review the patch?
Done, driver looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
| |