lkml.org 
[lkml]   [2016]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()
> >>  		if (tm->tm_year < 100) {
> >>- pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
> >>- 1900 + tm->tm_year);
> >>+ dev_warn(info->dev,
> >>+ "RTC can't handle year %d. Assume it's 2000\n",
> >>+ 1900 + tm->tm_year);
> >> return -EINVAL;
> >
> >Because we are returning an error value, why not use dev_err()?
> >
>
> You are absolutely right. Since the driver was using pr_warn(), I used
> dev_warn() but dev_err() would had been correct.
>
> If you don't mind I plan to do it as a follow up patch to avoid having
> to resend the whole series only for this change.

Fine for me!

Andi

\
 
 \ /
  Last update: 2016-01-27 04:01    [W:0.719 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site