lkml.org 
[lkml]   [2016]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARM: bcm: use const and __initconst for smp_operations
From
Date
Hi Masahiro,

On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
> This newly added code missed the global fixup by commit 75305275a721
> ("ARM: use const and __initconst for smp_operations"). So fix it now.
>
> Also, add missing "static" qualifier.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/mach-bcm/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 575defc..cfae9c7 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
> CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
> &bcm_smp_ops);
>
> -struct smp_operations nsp_smp_ops __initdata = {
> +static const struct smp_operations nsp_smp_ops __initconst = {
> .smp_prepare_cpus = bcm_smp_prepare_cpus,
> .smp_boot_secondary = nsp_boot_secondary,
> };
>

This fix looks good to me. Thanks!

Reviewed-by: Ray Jui <rjui@broadcom.com>

\
 
 \ /
  Last update: 2016-01-25 19:01    [W:0.080 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site