Messages in this thread | | | Date | Mon, 25 Jan 2016 16:09:33 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 14/26] perf tools: Introduce struct perf_hpp_list |
| |
On Tue, Jan 26, 2016 at 12:00:46AM +0900, Namhyung Kim wrote:
SNIP
> > void perf_hpp__cancel_cumulate(void) > > diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h > > index f3bcf2d38733..a9c8ccfcc284 100644 > > --- a/tools/perf/util/hist.h > > +++ b/tools/perf/util/hist.h > > @@ -226,20 +226,24 @@ struct perf_hpp_fmt { > > int idx; > > }; > > > > -extern struct list_head perf_hpp__list; > > -extern struct list_head perf_hpp__sort_list; > > +struct perf_hpp_list { > > + struct list_head list; > > + struct list_head sort_list; > > +}; > > What about this? > > struct perf_hpp_list { > struct list_head fields; > struct list_head sorts; > }; > > This also aligns with the option names.
yep, sounds better ;-)
thanks, jirka
| |