lkml.org 
[lkml]   [2016]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/15] dmaengine: dw: define counter variables as unsigned int
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    The code is fixed to satisfy a compiler otherwise we have

    drivers/dma/dw/core.c: In function ‘dwc_handle_cyclic’:
    drivers/dma/dw/core.c:568: warning: comparison between signed and unsigned
    drivers/dma/dw/core.c: In function ‘dw_dma_tasklet’:
    drivers/dma/dw/core.c:590: warning: comparison between signed and unsigned
    drivers/dma/dw/core.c: In function ‘dw_dma_off’:
    drivers/dma/dw/core.c:1103: warning: comparison between signed and unsigned
    drivers/dma/dw/core.c: In function ‘dw_dma_cyclic_free’:
    drivers/dma/dw/core.c:1469: warning: comparison between signed and unsigned
    drivers/dma/dw/core.c: In function ‘dw_dma_probe’:
    drivers/dma/dw/core.c:1574: warning: comparison between signed and unsigned

    There is no functional change.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Mans Rullgard <mans@mansr.com>
    ---
    drivers/dma/dw/core.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c
    index 28278e4c77ad..0853ade5e636 100644
    --- a/drivers/dma/dw/core.c
    +++ b/drivers/dma/dw/core.c
    @@ -551,7 +551,7 @@ static void dwc_handle_cyclic(struct dw_dma *dw, struct dw_dma_chan *dwc,
    */
    if (unlikely(status_err & dwc->mask) ||
    unlikely(status_xfer & dwc->mask)) {
    - int i;
    + unsigned int i;

    dev_err(chan2dev(&dwc->chan),
    "cyclic DMA unexpected %s interrupt, stopping DMA transfer\n",
    @@ -588,7 +588,7 @@ static void dw_dma_tasklet(unsigned long data)
    u32 status_block;
    u32 status_xfer;
    u32 status_err;
    - int i;
    + unsigned int i;

    status_block = dma_readl(dw, RAW.BLOCK);
    status_xfer = dma_readl(dw, RAW.XFER);
    @@ -1096,7 +1096,7 @@ static void dwc_issue_pending(struct dma_chan *chan)

    static void dw_dma_off(struct dw_dma *dw)
    {
    - int i;
    + unsigned int i;

    dma_writel(dw, CFG, 0);

    @@ -1438,7 +1438,7 @@ void dw_dma_cyclic_free(struct dma_chan *chan)
    struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
    struct dw_dma *dw = to_dw_dma(dwc->chan.device);
    struct dw_cyclic_desc *cdesc = dwc->cdesc;
    - int i;
    + unsigned int i;
    unsigned long flags;

    dev_dbg(chan2dev(&dwc->chan), "%s\n", __func__);
    @@ -1474,8 +1474,8 @@ int dw_dma_probe(struct dw_dma_chip *chip, struct dw_dma_platform_data *pdata)
    bool autocfg = false;
    unsigned int dw_params;
    unsigned int max_blk_size = 0;
    + unsigned int i;
    int err;
    - int i;

    dw = devm_kzalloc(chip->dev, sizeof(*dw), GFP_KERNEL);
    if (!dw)
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-01-24 20:41    [W:3.224 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site