Messages in this thread | | | Date | Sat, 23 Jan 2016 14:58:42 -0800 | From | Brian Norris <> | Subject | Re: [PATCH v8 5/7] mtd: nand: gpmi: add GPMI NAND support for i.MX7D |
| |
On Wed, Dec 02, 2015 at 04:47:44PM -0600, Han Xu wrote: > support GPMI NAND on i.MX7D > > Signed-off-by: Han Xu <b45815@freescale.com> > --- > drivers/mtd/nand/gpmi-nand/bch-regs.h | 14 +++++++------- > drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 10 ++++++---- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 27 ++++++++++++++++++++++----- > drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 7 +++++-- > 4 files changed, 40 insertions(+), 18 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/bch-regs.h b/drivers/mtd/nand/gpmi-nand/bch-regs.h > index 05bb91f..53e58bc 100644 > --- a/drivers/mtd/nand/gpmi-nand/bch-regs.h > +++ b/drivers/mtd/nand/gpmi-nand/bch-regs.h
...
> @@ -575,6 +581,10 @@ static char *extra_clks_for_mx6q[GPMI_CLK_MAX] = { > "gpmi_apb", "gpmi_bch", "gpmi_bch_apb", "per1_bch", > }; > > +static char *extra_clks_for_mx7d[GPMI_CLK_MAX] = { > + "gpmi_bch_apb", > +}; > + > static int gpmi_get_clks(struct gpmi_nand_data *this) > { > struct resources *r = &this->resources; > @@ -592,6 +602,8 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) > /* Get extra clocks */ > if (GPMI_IS_MX6(this)) > extra_clks = extra_clks_for_mx6q; > + if (GPMI_IS_MX7(this)) > + extra_clks = extra_clks_for_mx7d; > if (!extra_clks) > return 0; >
...
It looks like these clock names were never documented. Shouldn't this be part of Documentation/devicetree/bindings/mtd/gpmi-nand.txt?
Otherwise, the patch looks good to me.
Brian
| |