lkml.org 
[lkml]   [2016]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] block: fix bio splitting on max sectors
From
Date
On 01/22/2016 05:05 PM, Ming Lei wrote:
> After commit e36f62042880(block: split bios to maxpossible length),
> bio can be splitted in the middle of a vector entry, then it
> is easy to split out one bio which size isn't aligned with block
> size, especially when the block size is bigger than 512.
>
> This patch fixes the issue by making the max io size aligned
> to logical block size.
>
> Fixes: e36f62042880(block: split bios to maxpossible length)
> Reported-by: Stefan Haberland <sth@linux.vnet.ibm.com>
> Cc: Keith Busch <keith.busch@intel.com>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> V1:
> - avoid double shift as suggested by Linus
> - compute 'max_sectors' once as suggested by Keith

This looks good to me, I'll apply and run a bit of local testing.

--
Jens Axboe

\
 
 \ /
  Last update: 2016-01-23 05:01    [W:0.059 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site