lkml.org 
[lkml]   [2016]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware()
    On 01/01/2016 08:26 PM, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Fri, 1 Jan 2016 20:20:15 +0100

    I think it has been said over and over, but please use driver name only
    as prefix. I don't see value to prepend it with 'net-'.

    > Omit explicit initialisation at the beginning for one local variable
    > that is redefined before its first use.
    >

    That being said here is my....

    Acked-by: Arend van Spriel <arend@broadcom.com>
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
    > index ceb2a75..c21eeb1 100644
    > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
    > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
    > @@ -3260,7 +3260,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus,
    > const struct firmware *fw,
    > void *nvram, u32 nvlen)
    > {
    > - int bcmerror = -EFAULT;
    > + int bcmerror;
    > u32 rstvec;
    >
    > sdio_claim_host(bus->sdiodev->func[1]);
    >



    \
     
     \ /
      Last update: 2016-01-02 10:21    [W:4.775 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site