Messages in this thread | | | From | covici@ccs ... | Subject | Re: [PATCH] Staging: speakup: Fix getting port information | Date | Sat, 02 Jan 2016 20:31:11 -0500 |
| |
Well, OK with me, I will use yours instead because I don't know if they will backport the thing, thanks so much for doing this.
Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> covici@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it > > here for your information. > > Well, it's not up to serialio.h to include things for serialio.c. That > however makes me realize that the culprit is actually > f79b0d9 (which actually doesn't make much sense since linux/serial.h is > getting included a couple of lines above...). > > I don't know what this "use <linux/serial.h> instead <asm/serial.h>" > warning is about, but *no* header in include/ includes asm/serial.h, so > there is no way to get the SERIAL_PORT_DFNS definition just by including > linux/serial.h, we really need asm/serial.h, just like 8250*.c do. > > So we really need serialio.c to include linux/serial_core.h then > asm/serial.h, as my patch does. > > Samuel > _______________________________________________ > Speakup mailing list > Speakup@linux-speakup.org > http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup >
-- Your life is like a penny. You're going to lose it. The question is: How do you spend it?
John Covici covici@ccs.covici.com
| |