lkml.org 
[lkml]   [2016]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 048/160] usb: xhci: fix config fail of FS hub behind a HS hub with MTT
    Date
    3.19.8-ckt13 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Chunfeng Yun <chunfeng.yun@mediatek.com>

    commit 096b110a3dd3c868e4610937c80d2e3f3357c1a9 upstream.

    if a full speed hub connects to a high speed hub which
    supports MTT, the MTT field of its slot context will be set
    to 1 when xHCI driver setups an xHCI virtual device in
    xhci_setup_addressable_virt_dev(); once usb core fetch its
    hub descriptor, and need to update the xHC's internal data
    structures for the device, the HUB field of its slot context
    will be set to 1 too, meanwhile MTT is also set before,
    this will cause configure endpoint command fail, so in the
    case, we should clear MTT to 0 for full speed hub according
    to section 6.2.2

    Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
    Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/usb/host/xhci.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
    index 6358446..2142e96 100644
    --- a/drivers/usb/host/xhci.c
    +++ b/drivers/usb/host/xhci.c
    @@ -4793,8 +4793,16 @@ int xhci_update_hub_device(struct usb_hcd *hcd, struct usb_device *hdev,
    ctrl_ctx->add_flags |= cpu_to_le32(SLOT_FLAG);
    slot_ctx = xhci_get_slot_ctx(xhci, config_cmd->in_ctx);
    slot_ctx->dev_info |= cpu_to_le32(DEV_HUB);
    + /*
    + * refer to section 6.2.2: MTT should be 0 for full speed hub,
    + * but it may be already set to 1 when setup an xHCI virtual
    + * device, so clear it anyway.
    + */
    if (tt->multi)
    slot_ctx->dev_info |= cpu_to_le32(DEV_MTT);
    + else if (hdev->speed == USB_SPEED_FULL)
    + slot_ctx->dev_info &= cpu_to_le32(~DEV_MTT);
    +
    if (xhci->hci_version > 0x95) {
    xhci_dbg(xhci, "xHCI version %x needs hub "
    "TT think time and number of ports\n",
    --
    1.9.1

    \
     
     \ /
      Last update: 2016-01-20 03:01    [W:2.616 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site