Messages in this thread | | | Subject | Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP | From | Krzysztof Kozlowski <> | Date | Mon, 18 Jan 2016 13:23:26 +0900 |
| |
On 14.01.2016 23:20, Mark Brown wrote: > On Thu, Jan 14, 2016 at 10:20:56AM +0900, Krzysztof Kozlowski wrote: > >> 2. It has different register address. >> We need a register-layout/configuration structure. The logic is the >> same except few differences (e.g. presence of MAX77802_RTC_AE1). > > Depending on what the differences are either just some variables in the > driver data that get set on probe with the different registers (if it's > just the register) or using regmap_field (if things get shifted as well, > or if it happens to make more sense) should work.
Thanks for the hints!
The addresses for registers are indeed shifted. It is non-linear because apart of different offset at beginning, a new field appears. Anyway it would be good for me (or other person doing this work) to get more knowledge of what regmap API provides.
Best regards, Krzysztof
| |