Messages in this thread | | | Date | Tue, 12 Jan 2016 15:47:18 -0500 (EST) | Subject | Re: [PATCH net] phonet: properly unshare skbs in phonet_rcv() | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 12 Jan 2016 08:58:00 -0800
> From: Eric Dumazet <edumazet@google.com> > > Ivaylo Dimitrov reported a regression caused by commit 7866a621043f > ("dev: add per net_device packet type chains"). > > skb->dev becomes NULL and we crash in __netif_receive_skb_core(). > > Before above commit, different kind of bugs or corruptions could happen > without major crash. > > But the root cause is that phonet_rcv() can queue skb without checking > if skb is shared or not. > > Many thanks to Ivaylo Dimitrov for his help, diagnosis and tests. > > Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Remi Denis-Courmont <courmisch@gmail.com>
Applied and queued up for -stable, th anks Eric.
| |