lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: ion : Donnot wakeup kswapd in ion system alloc
From
Date
On 01/12/2016 03:14 AM, Chen Feng wrote:
> Since ion alloc can be called by userspace,eg gralloc.
> When it is called frequently, the efficiency of kswapd is
> to low. And the reclaimed memory is too lower. In this way,
> the kswapd can use to much cpu resources.
>
> With 3.5GB DMA Zone and 0.5 Normal Zone.
>
> pgsteal_kswapd_dma 9364140
> pgsteal_kswapd_normal 7071043
> pgscan_kswapd_dma 10428250
> pgscan_kswapd_normal 37840094
>
> With this change the reclaim ratio has greatly improved
> 18.9% -> 72.5%
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Lu bing <albert.lubing@hisilicon.com>
> ---
> drivers/staging/android/ion/ion_system_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index d4c3e55..b69dfc7 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -27,7 +27,7 @@
> #include "ion_priv.h"
>
> static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
> - __GFP_NORETRY) & ~__GFP_DIRECT_RECLAIM;
> + __GFP_NORETRY) & ~__GFP_RECLAIM;
> static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
> static const unsigned int orders[] = {8, 4, 0};
> static const int num_orders = ARRAY_SIZE(orders);
>

Makes sense given what the code is actually trying to do and the data presented
here.

Reviewed-by: Laura Abbott <labbott@redhat.com>

\
 
 \ /
  Last update: 2016-01-12 18:41    [W:0.050 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site