lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
    On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
    > This patchset fixes a regression introduced by
    > commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
    > for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
    >
    > Changes vs. v1:
    > - fixed reference to the commit that introduced the regression.
    > - dropped patch to use gpiod framework. This should be added later,
    > after the affected DTBs have been updated to specify the correct
    > gpio_flags.
    >
    > Patch overview:
    > 1. cleanup patch to remove redundant NULL checks
    > 2. call fec_reset_phy() after the ENET_OUT clock has been enabled

    I definitely want to test these on my SolidRun boards before these get
    merged: the AR8035 on there is configured via pin-straps, and then
    further tweaked with PHY quirks. Resetting with the iMX6 in the
    wrong state may result in the AR8035 being reconfigured (even jumping
    to a different MDIO address) and certainly would need the PHY quirks
    re-running.

    --
    RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
    FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
    according to speedtest.net.

    \
     
     \ /
      Last update: 2016-01-12 17:21    [W:3.815 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site