lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
Date
On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote:
> On 12/01/16 14:00, Arnd Bergmann wrote:
> > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >> To be consistent with other nodes move sdhci node under the soc node,
> >> rather than using lable references.
> >>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> > Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>

Ok, nevermind then.

> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we
> delete all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to
> the reader, removing them might not add great value.

Fair enough.

Arnd

\
 
 \ /
  Last update: 2016-01-12 16:41    [W:0.055 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site