lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][4.1.15-rt17 PATCH] mm: swap: lru drain don't use workqueue with PREEMPT_RT_FULL
On Sun, 10 Jan 2016, l@dorileo.org wrote:
> +#ifdef CONFIG_PREEMPT_RT_FULL
> +void lru_add_drain_all(void)
> +{
> + static DEFINE_MUTEX(lock);
> + int cpu;
> +
> + mutex_lock(&lock);
> + get_online_cpus();
> +
> + for_each_online_cpu(cpu) {
> + smp_call_function_single(cpu, lru_add_drain, NULL, 1);

How is that supposed to work on RT? Not at all, because lru_add_drain() takes
'sleeping' spinlocks and you cannot do that from hard interrupt context.

Enable lockdep (what you should have done before posting) and watch the
fireworks.

Thanks,

tglx


\
 
 \ /
  Last update: 2016-01-12 13:41    [W:0.059 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site