Messages in this thread | | | Date | Tue, 12 Jan 2016 10:41:10 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/6] perf tools: Add -lutil in python lib list for broken python-config |
| |
On Mon, Jan 11, 2016 at 05:50:21PM +0800, Wangnan (F) wrote:
SNIP
> > > > Using this option has a significant performance cost. It is best to > >use it only when there are unavoidable circular references between two or > >more archives. > ></quote> > > > >Without --start/end-group, if we provide -l in this order: > > > > ... -la -lb -lc ... > > > >and libb.a requires a symbol in liba.a, link would fail. The simplest way > >to avoid this is to add another -la after -lb: > > > > ... -la -lb -la -lc ... > > > >In my environment it works as if we don't provide -Wl,--start-group and > >-Wl,--end-group. > >I don't know why. > > > > I mean the python case before I add -lutil after python libs. > -Wl,--start-group and -Wl,--end-group > seems not work for me. They are issued, I confirm this in strace output.
ok, got it.. I'm ok with the patch, there's no harm with extra lib, however I think you should report this to gcc folks
also please resubmit the patch with the above comment, to make it clear why it's there
thanks, jirka
| |