lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic
    On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote:

    > +config REGULATOR_HI655X
    > + tristate "Hisilicon HI655X PMIC regulators support"
    > + depends on ARCH_HISI || (COMPILE_TEST && ARM64)

    Why does this depend on ARM64? If it's needed it probably indicates a
    problem...

    > + np = of_get_child_by_name(dev->parent->of_node, "regulators");
    > + if (!np)
    > + return -ENODEV;
    > +
    > + ret = of_regulator_match(dev, np,
    > + hi655x_regulator_match,
    > + ARRAY_SIZE(hi655x_regulator_match));

    Like I said on the previous version:

    | Don't open code this, use the standard support with of_match and
    | regulators_node.

    The code is now using of_match but still open coding regulators_node.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-01-11 19:41    [W:4.153 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site