Messages in this thread | | | Date | Mon, 11 Jan 2016 18:24:44 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic |
| |
On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote:
> +config REGULATOR_HI655X > + tristate "Hisilicon HI655X PMIC regulators support" > + depends on ARCH_HISI || (COMPILE_TEST && ARM64)
Why does this depend on ARM64? If it's needed it probably indicates a problem...
> + np = of_get_child_by_name(dev->parent->of_node, "regulators"); > + if (!np) > + return -ENODEV; > + > + ret = of_regulator_match(dev, np, > + hi655x_regulator_match, > + ARRAY_SIZE(hi655x_regulator_match));
Like I said on the previous version:
| Don't open code this, use the standard support with of_match and | regulators_node.
The code is now using of_match but still open coding regulators_node. [unhandled content-type:application/pgp-signature] | |