Messages in this thread | | | Date | Mon, 11 Jan 2016 12:58:37 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 11/53] perf test: Fix false TEST_OK result for 'perf test hist' |
| |
Em Mon, Jan 11, 2016 at 05:25:48PM +0300, Sergei Shtylyov escreveu: > On 01/11/2016 04:48 PM, Wang Nan wrote: > > >Commit 71d6de64feddd4b455555326fba2111b3006d9e0 ('perf test: Fix hist > >testcases when kptr_restrict is on') solves a double free problem when > > You didn't run this patch thru scripts/checkpatch.pl, I guess? A > certain commit citing style is enforced now, and yours doesn't quite > match it...
Which is? /me goes to read checpatch.pl...
- Arnaldo
> >'perf test hist' calling setup_fake_machine(). However, the result is > >still incorrect. For example: > > > > $ ./perf test -v 'filtering hist entries' > > 25: Test filtering hist entries : > > --- start --- > > test child forked, pid 4186 > > Cannot create kernel maps > > test child finished with 0 > > ---- end ---- > > Test filtering hist entries: Ok > > > >In this case the body of this test is not get executed at all, but the > >result is 'Ok'. > > > >Actually, in setup_fake_machine() there's no need to create real kernel > >maps. What we want is the fake maps. This patch removes the > >machine__create_kernel_maps() in setup_fake_machine(), so it won't be > >affected by kptr_restrict setting. > > > >Test result: > > > > $ cat /proc/sys/kernel/kptr_restrict > > 1 > > $ ~/perf test -v hist > > 15: Test matching and linking multiple hists : > > --- start --- > > test child forked, pid 24031 > > test child finished with 0 > > ---- end ---- > > Test matching and linking multiple hists: Ok > > [SNIP] > > > >Signed-off-by: Wang Nan <wangnan0@huawei.com> > >Suggested-by: Namhyung Kim <namhyung@kernel.org> > >Acked-by: Namhyung Kim <namhyung@kernel.org> > >Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > >Cc: Jiri Olsa <jolsa@kernel.org> > >Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > [...] > > MBR, Sergei
| |